-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Microsoft's DOM Events tests into position. #56
Conversation
Hey! I want to get my feet wet reviewing tests. Since this PR is some of Microsoft's old test submissions (and these tests need some help), I thought I'd start here. Do you mind if I file a bunch of issues? Alternately, I'd be happy to code up the fixes for these as well. |
Hi @travisleithead—I'd suggest using critic to review this PR: https://critic.hoppipolla.co.uk/r/33 |
@travisleithead this PR seems to still be waiting your review |
Yep--I've been directing my energy into locking down DOM L3 Events, which interestingly, is moving some of the generic event dispatch stuff out of the spec, so that its only defined in terms of DOM4 (not both in DOM4 and in DOML3 Events). Since that work will have an impact on what needs to be tested for DOM L3 Events and what tests needs to be moved under DOM, I've been holding off on this. |
I don't expect us to use this PR for anything at this point. |
fixup! Eliminate constructs that prevent passing routes across processes...
Fix reading of wdspec items in manifest; r=Ms2ger
Split test_path parsing into its own function.
Native English speaker fixes
No description provided.