Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Microsoft's DOM Events tests into position. #56

Closed
wants to merge 2 commits into from

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Apr 4, 2013

No description provided.

@travisleithead
Copy link
Contributor

Hey! I want to get my feet wet reviewing tests. Since this PR is some of Microsoft's old test submissions (and these tests need some help), I thought I'd start here. Do you mind if I file a bunch of issues? Alternately, I'd be happy to code up the fixes for these as well.

@Ms2ger Ms2ger closed this Apr 18, 2014
@Ms2ger Ms2ger reopened this Apr 18, 2014
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Apr 18, 2014

Hi @travisleithead—I'd suggest using critic to review this PR: https://critic.hoppipolla.co.uk/r/33

@sideshowbarker
Copy link
Member

Hi @travisleithead—I'd suggest using critic to review this PR: https://critic.hoppipolla.co.uk/r/33

@travisleithead this PR seems to still be waiting your review

@travisleithead
Copy link
Contributor

Yep--I've been directing my energy into locking down DOM L3 Events, which interestingly, is moving some of the generic event dispatch stuff out of the spec, so that its only defined in terms of DOM4 (not both in DOM4 and in DOML3 Events). Since that work will have an impact on what needs to be tested for DOM L3 Events and what tests needs to be moved under DOM, I've been holding off on this.

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Feb 24, 2015

I don't expect us to use this PR for anything at this point.

@Ms2ger Ms2ger closed this Feb 24, 2015
@sideshowbarker sideshowbarker deleted the submission/Microsoft/DOMEvents branch June 18, 2015 07:24
jgraham added a commit that referenced this pull request Apr 13, 2017
fixup! Eliminate constructs that prevent passing routes across processes...
jgraham pushed a commit that referenced this pull request Apr 13, 2017
Fix reading of wdspec items in manifest; r=Ms2ger
jgraham added a commit that referenced this pull request Apr 21, 2017
Split test_path parsing into its own function.
AutomatedTester referenced this pull request in AutomatedTester/web-platform-tests Dec 1, 2017
Native English speaker fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants