Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update webpack and webpack-cli #2992

Merged
merged 2 commits into from
Feb 12, 2021
Merged

chore: update webpack and webpack-cli #2992

merged 2 commits into from
Feb 12, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes, updated tests.

Motivation / Use-Case

update webpack and webpack-cli to lates version.

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #2992 (70ce564) into master (ad6619b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2992   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files          37       37           
  Lines        1262     1262           
  Branches      326      326           
=======================================
  Hits         1166     1166           
  Misses         91       91           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad6619b...70ce564. Read the comment docs.

done();
})
.catch(done);
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not delete this tests, let's improve testing here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we don't default host so we can change the assertion to false.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

host should be in IPv6 here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see running at http:/ without specifying host and port -

Screenshot at 2021-02-06 10-31-20

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug 😄

Copy link
Member

@alexander-akait alexander-akait Feb 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should print message like Project is running at https://server.com or Project is running at IPv4 (IPv6), it is in my roadmap, give me tomorrow to improve this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need an update here?

const prettyPrintUrl = (newHostname) =>
url.format({ protocol, hostname: newHostname, port, pathname: '/' });
let prettyHostname;
let lanUrlForTerminal;
if (hostname === '0.0.0.0' || hostname === '::') {
prettyHostname = 'localhost';
const localIP =
hostname === '::' ? internalIp.v6.sync() : internalIp.v4.sync();
if (localIP) {
lanUrlForTerminal = prettyPrintUrl(localIP);
}
} else {
prettyHostname = hostname;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need improve it here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (typeof hostname === 'undefined') { 
  prettyHostName = ?? // what should be printed here?
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, I need to look at code, why hostname here undefined 😕

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge as is, to unblock other deps updating and solve messages in the next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants