Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: syncronize cli-flags for webpack-cli < v4.6.0 #3153

Merged
merged 5 commits into from
Apr 5, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No

Motivation / Use-Case

We have some additional flags currently present only with webpack-cli v4.6.0 -

--no-bonjour
--no-client-progress
--no-open
--no-open-target

Breaking Changes

None

Additional Info

No

alexander-akait
alexander-akait previously approved these changes Apr 5, 2021
@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #3153 (dc6851b) into master (f140f2a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3153   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files          37       37           
  Lines        1218     1218           
  Branches      338      338           
=======================================
  Hits         1157     1157           
  Misses         55       55           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f140f2a...dc6851b. Read the comment docs.

@alexander-akait
Copy link
Member

@snitin315 Let's rebase ⭐

@alexander-akait alexander-akait merged commit 2d51e02 into master Apr 5, 2021
@alexander-akait alexander-akait deleted the fix/sync-flags branch April 5, 2021 18:36
@alexander-akait
Copy link
Member

Thanks

@snitin315
Copy link
Member Author

Thanks for the rebase 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants