-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wechaty-puppet-oa #24
Conversation
…ion is always defined-!!resolve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create an issue and explain what problem that your PR has solved in detail so that we can begin discussing based on that.
Thank you very much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have some basic problems, please go ahead to fix them.
And more, you haven't implemented any new interfaces, I hope you can devote more energy to it in the future.
Thanks for your work, please go ahead.
.vscode/launch.json
Outdated
@@ -11,7 +11,7 @@ | |||
"skipFiles": [ | |||
"<node_internals>/**" | |||
], | |||
"runtimeArgs": ["-r", "/usr/local/lib/node_modules/ts-node/register"], | |||
"runtimeArgs": ["-r", "F:/nodejs/node_global/node_modules/ts-node/register"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not sumbit this file which is the yourself configuraiton.
examples/ding-dong-bot.ts
Outdated
/* eslint-disable quotes */ | ||
/* eslint-disable eqeqeq */ | ||
/* eslint-disable space-before-blocks */ | ||
/* eslint-disable indent */ | ||
/* eslint-disable no-irregular-whitespace */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These eslint is the standard lint for typescript program language, please remve them and I believe you can fix them.
examples/ding-dong-bot.ts
Outdated
appId : 'wx7deefc328fabc691', | ||
appSecret : '761abc880bf822082da9f41a6e3a5dd1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the configuraiton of your account. For the security of your account, you should not upload this configuration.
src/official-account/lt.js
Outdated
const localtunnel = require('localtunnel'); | ||
|
||
(async () => { | ||
const tunnel = await localtunnel({ | ||
port: 3000, | ||
}); | ||
|
||
// the assigned public url for your tunnel | ||
// i.e. https://abcdefgjhij.localtunnel.me | ||
console.log(tunnel.url) | ||
|
||
tunnel.on('close', () => { | ||
// tunnels are closed | ||
}); | ||
})(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
localtunnel is the optional configuration for developer not the required config, so you should not add this file.
Hi, I have upgraded this module to ESM via #25 , please sync with the latest version of the main branch code. BTW: Do we have any new progress on our project? I hope we can at least merge a PR for each week, with a clear improvement. |
No description provided.