Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wechaty-puppet-oa #24

Closed
wants to merge 27 commits into from
Closed

Update wechaty-puppet-oa #24

wants to merge 27 commits into from

Conversation

zzzyer
Copy link
Contributor

@zzzyer zzzyer commented Aug 20, 2021

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create an issue and explain what problem that your PR has solved in detail so that we can begin discussing based on that.

Thank you very much!

Copy link
Contributor

@wj-Mcat wj-Mcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have some basic problems, please go ahead to fix them.

And more, you haven't implemented any new interfaces, I hope you can devote more energy to it in the future.

Thanks for your work, please go ahead.

@@ -11,7 +11,7 @@
"skipFiles": [
"<node_internals>/**"
],
"runtimeArgs": ["-r", "/usr/local/lib/node_modules/ts-node/register"],
"runtimeArgs": ["-r", "F:/nodejs/node_global/node_modules/ts-node/register"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not sumbit this file which is the yourself configuraiton.

Comment on lines 1 to 5
/* eslint-disable quotes */
/* eslint-disable eqeqeq */
/* eslint-disable space-before-blocks */
/* eslint-disable indent */
/* eslint-disable no-irregular-whitespace */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These eslint is the standard lint for typescript program language, please remve them and I believe you can fix them.

Comment on lines 42 to 43
  appId           : 'wx7deefc328fabc691',
  appSecret       : '761abc880bf822082da9f41a6e3a5dd1',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the configuraiton of your account. For the security of your account, you should not upload this configuration.

Comment on lines 1 to 15
const localtunnel = require('localtunnel');

(async () => {
const tunnel = await localtunnel({
port: 3000,
});

// the assigned public url for your tunnel
// i.e. https://abcdefgjhij.localtunnel.me
console.log(tunnel.url)

tunnel.on('close', () => {
// tunnels are closed
});
})();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

localtunnel is the optional configuration for developer not the required config, so you should not add this file.

@huan
Copy link
Member

huan commented Sep 12, 2021

Hi, I have upgraded this module to ESM via #25 , please sync with the latest version of the main branch code.

BTW: Do we have any new progress on our project? I hope we can at least merge a PR for each week, with a clear improvement.

@zzzyer zzzyer closed this Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants