Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0 Roadmap #193

Closed
4 tasks done
bw4sz opened this issue Jun 3, 2021 · 14 comments
Closed
4 tasks done

1.0 Roadmap #193

bw4sz opened this issue Jun 3, 2021 · 14 comments

Comments

@bw4sz
Copy link
Collaborator

bw4sz commented Jun 3, 2021

@ethanwhite and @henrykironde

We need to create a roadmap that we agree on for how to bring together

DeepForest-pytorch and DeepForest

Let's start by agreeing on the end goal. We want a single repo that holds a main branch that points to pytorch and a tensorflow branch that will have deprecation notice. I'm agnostic to the git history, i'm not sure its worth the time to do a massive effort for bringing the two files under version control. I vote for keeping the pytorch git history and have a clean git history that holds the deprecated tensorflow code.

Specific objectives

anything else?

@bw4sz bw4sz added this to the 1.0 milestone Jun 3, 2021
@ethanwhite
Copy link
Member

ethanwhite commented Jun 4, 2021

I agree with the overall goal.

I vote for keeping the pytorch git history and have a clean git history that holds the deprecated tensorflow code.

We can easily have separate histories for the two branches, which reflects the reality of how they were developed. I'm happy to take care of this as soon as we're ready.

I think little clean up/management things to add include:

@henrykironde
Copy link
Contributor

  • Update the release
  • Update the conda package

@bw4sz
Copy link
Collaborator Author

bw4sz commented Jun 4, 2021

#195

@bw4sz
Copy link
Collaborator Author

bw4sz commented Jun 5, 2021

There is now a main branch that holds the pytorch versus, which is default, and a tensorflow version that holds the original.

@henrykironde
Copy link
Contributor

@bw4sz there are a few changes required after the change to main. These are some of the files that we may have to change
https://github.com/weecology/DeepForest/search?q=master

let me know if you want me to make those changes, In case you have not started.

@bw4sz
Copy link
Collaborator Author

bw4sz commented Jun 5, 2021 via email

@bw4sz
Copy link
Collaborator Author

bw4sz commented Jun 6, 2021

https://deepforest.readthedocs.io/en/latest/ now builds pytorch docs.

@bw4sz
Copy link
Collaborator Author

bw4sz commented Jun 6, 2021

New release that matches pytorch https://github.com/weecology/DeepForest/releases/tag/1.0.0

@bw4sz
Copy link
Collaborator Author

bw4sz commented Jun 6, 2021

added note in deepforest-pytorch to point users here.

@bw4sz
Copy link
Collaborator Author

bw4sz commented Jun 7, 2021

pypi deepforest release points to main branch at 1.0.0

https://pypi.org/manage/project/deepforest/release/1.0.0/

@bw4sz
Copy link
Collaborator Author

bw4sz commented Jun 7, 2021

@henrykironde can I assign you ethan's request that

Redirect pip installs of deepforest-pytorch to deepforest: https://github.com/simonw/pypi-rename

@bw4sz
Copy link
Collaborator Author

bw4sz commented Jun 8, 2021

cleaned up old issues.

@bw4sz
Copy link
Collaborator Author

bw4sz commented Jun 9, 2021

Added note to the front of tensorflow branch on updating model.

https://github.com/weecology/DeepForest/blob/tensorflow/README.md

@bw4sz
Copy link
Collaborator Author

bw4sz commented Jun 16, 2021

Added issues in active downstream repos.

@bw4sz bw4sz closed this as completed Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants