forked from nxtmeta/go-nxtmeta
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement API to get brioche configuration #86
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we attach a node to the mainnet now and look it up, it comes out as follows.
But shouldn't it be like this?
|
jed-wemade
reviewed
May 24, 2024
paul-ahn-wm
reviewed
May 24, 2024
steve-oh-wt
reviewed
May 25, 2024
paul-ahn-wm
approved these changes
May 28, 2024
Noah-jhkim
reviewed
May 28, 2024
jed-wemade
reviewed
May 28, 2024
jed-wemade
approved these changes
May 28, 2024
egonspace
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced May 29, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77
The implemented API is as follows.
wemix
wemix_briocheConfig
wemix_halvingSchedule
wemix_getBriocheBlockReward
To expose the Brioche API via the Websocket/HTTP RPC interface, need to add the
--http(ws).api "wemix"
flag or append"wemix"
toHttp(Ws)Modules
in thenode.config
.Closes #77