test: Skip bison tests if bison is not available #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explorer09
force-pushed
the
tests-fix-2
branch
from
0e218b7 to
ed272ac
Compare
|
Would you put the README change on a separate pr, please. It is not related to the bison changes. |
Explorer09
force-pushed
the
tests-fix-2
branch
from
ed272ac to
bfd28d9
Compare
|
Update: the tests/README change is on separate pull request now: #148 |
Explorer09
force-pushed
the
tests-fix-2
branch
from
bfd28d9 to
af675d0
Compare
|
There's conflicts now. Would you fix that and push the update? Go ahead and squash/fixup the history as appropriate, too. |
AC_PROG_YACC already detects the bison program. We can just use it, and make notice if [ $YACC != 'bison -y' ] Remove unused AC_SUBST([BISON], ...). Add AM_CONDITIONAL([HAVE_BISON], ...) so that we can skip bison tests in testsuite.
Explorer09
force-pushed
the
tests-fix-2
branch
from
af675d0 to
4c124da
Compare
|
You need to add the no_bison_stub.c. |
Explorer09
force-pushed
the
tests-fix-2
branch
from
4c124da to
12c3fda
Compare
|
Rebased and added no_bison_stub.c. (And would you please be patient and wait a bit before I say it's okay? I was tweaking the no_bison_stub.c when I discovered that it's not included in the commit just now.) |
|
You bet, just holler when.
…On Tuesday, 24 January 2017, 5:34 pm -0800, "Kang-Che Sung (宋岡哲)" ***@***.***> wrote:
Rebased and added no_bison_stub.c. (And would you please be patient and wait a bit before I say it's okay? I was tweaking the no_bison_stub.c when I discovered that it's not included in the commit just now.)
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#145 (comment)
--
Will Estes
[email protected]
|
|
It's ready to pull now. |
|
Thanks. This is on master and will be included in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request depends on #144
Resolves #49, except that this configure script is not tolerant on other yacc implementations (byacc, for example). If someone wants byacc for building flex and/or the testsuite, just tweak the code then.