Include the legacy namespace identifier in both interface prototype objects and platform objects. #577
Conversation
index.bs
Outdated
| 1. If |I| has a [{{LegacyNamespace}}] [=extended attribute=], then: | ||
| 1. Let |namespace| be the identifier argument of the [{{LegacyNamespace}}] | ||
| [=extended attribute=]. | ||
| 1. Return the concatenation of |namespace|, ".", and |interface|. |
There was a problem hiding this comment.
Maybe link infra concatenate?
There was a problem hiding this comment.
I always forget that exists. Thanks.
|
The title of this PR seems to be more like #357, but the diff seems to be about legacynamespace interfaces only. |
index.bs
Outdated
|
|
||
| The <dfn>qualified name</dfn> of an [=interface=] |I| is defined as follows: | ||
|
|
||
| 1. Let |interface| be the [=identifier=] of |I|. |
There was a problem hiding this comment.
I'd encourage not using any one-letter variables any more. How about "Let identifier be the identifier of interface"?
index.bs
Outdated
| 1. Let |namespace| be the identifier argument of the [{{LegacyNamespace}}] | ||
| [=extended attribute=]. | ||
| 1. Return the [=concatenation=] of « |namespace|, |interface| » with | ||
| separator ".". |
Ms2ger
changed the title
|
Review ping? |
| 1. Let |namespace| be the identifier argument of the [{{LegacyNamespace}}] | ||
| [=extended attribute=]. | ||
| 1. Return the [=concatenation=] of « |namespace|, |identifier| » with | ||
| separator <span class="char">U+002E FULL STOP (".")</span>. |
There was a problem hiding this comment.
A bit unsure if (".") needs to be in the <span class=char> as well…
There was a problem hiding this comment.
Looking at the existing spec for about ten seconds yields
<span class="char">U+005F LOW LINE ("_")</span>There was a problem hiding this comment.
Oops yeah I did find that but forgot to comment here afterwards. SGTM.
|
I'd be happy to rebase & merge this provided we don't enforce commit message guidelines for IDL. @domenic? |
…bject This removes prose that references class strings of interfaces and namespaces, neither of which have such a thing. (Class strings are defined only for JavaScript objects.)
In both interface prototype objects and platform objects. There does not seem to be a reason to omit the namespace there.
Preview | Diff