Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge from upstream #1

Merged
merged 22 commits into from
Dec 23, 2016
Merged

merge from upstream #1

merged 22 commits into from
Dec 23, 2016

Conversation

wheelcomplex
Copy link
Owner

No description provided.

franxois and others added 22 commits March 10, 2015 23:55
Changes typo line 58 log.Print(format,value) to log.Printf
- Current implementation will flush both Input and Output buffers
- Added Flush to Windows calling PurgeComm()
- Added Flush to POSIX calling tcflush()
- Added Flush to Linux using syscall IOCTL with TCFLSH
- Tested on Windows, POSIX and Linux environment
- Removed reduntant File Descriptor field stored in Port structure
  for Linux and POSIX implementations
Adding Flush() to flush serial port I/O buffers
Fixed typo in usage code example
serial: update sample import
… waiting for the read timeout when doing a read with a timeout. Fixes #31
22: no new variables on left side of :=
…ng case.

The MSDN documentation is unclear on what happens when it's set to
MAXDWORD.  I don't have the capability to test across different
windows versions with multiple serial devices, so this seems to be the
safer option since this is what other libraries seem to do.

For example here:
http://forums.ni.com/attachments/ni/140/18925/1/SerialENETWrite.cpp

This link suggests another option for Blocking:
http://stackoverflow.com/questions/10390151/how-do-i-use-commtimeouts-to-wait-until-bytes-are-available-but-read-more-than-o

The documentation is poor about these different corner cases, but
MAXDWORD-1 seems to be a fairly safe choice.
This is discussed in these PRs:
#34
#38
Add support for missing baudrates between 50 and 1200.

Also closes #41
@wheelcomplex wheelcomplex merged commit 93ef5ac into wheelcomplex:master Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants