Skip to content

Commit a3e0998

Browse files
authored
Fix install dependency for python 3.11 (#1155)
## Description Addresses #1154 and updates test matrix to cover python 3.11 and adds windows os. - Upgrade poetry from 1.2.1 to 1.4.1 - updated several dependency versions conditionally on python 3.11: scikit-learn, scipy, numpy, pyarrow, typing-extensions - whylabs-client version range tighten to prevent future breaking changes in major version bump accidentally being considered compatible with older versions of whylogs. - refactor datasets module to pass type checking - skip pyspark tests until there is a pyspark version released that supports python 3.11 - [x] I have reviewed the [Guidelines for Contributing](CONTRIBUTING.md) and the [Code of Conduct](CODE_OF_CONDUCT.md).
1 parent ba29ca5 commit a3e0998

File tree

13 files changed

+2080
-2057
lines changed

13 files changed

+2080
-2057
lines changed

.github/workflows/push-release.yml

+7-3
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ defaults:
99
run:
1010
working-directory: python
1111

12+
env:
13+
POETRY_VERSION: "1.4.1"
14+
PROTOC_VERSION: "3.19.4"
15+
1216
jobs:
1317
deploy:
1418
runs-on: ubuntu-latest
@@ -22,12 +26,12 @@ jobs:
2226
- name: Install Poetry
2327
uses: abatilo/[email protected]
2428
with:
25-
poetry-version: 1.2.1
29+
poetry-version: ${{ env.POETRY_VERSION }}
2630

2731
- name: Install Protoc
2832
uses: arduino/setup-protoc@v1
2933
with:
30-
version: "3.19.4"
34+
version: ${{ env.PROTOC_VERSION }}
3135
repo-token: ${{ secrets.GITHUB_TOKEN }}
3236
- name: Cache Python dependencies
3337
uses: actions/cache@v3
@@ -37,7 +41,7 @@ jobs:
3741
restore-keys: |
3842
${{ runner.os }}-pip-
3943
- name: Install dependencies
40-
run: make install
44+
run: make telemetry-opt-out install
4145

4246
- name: Autobump version
4347
run: |

.github/workflows/test-notebook.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ defaults:
1313

1414
env:
1515
CODECOV_UPLOAD: false
16-
POETRY_VERSION: "1.2.1"
16+
POETRY_VERSION: "1.4.1"
1717
PROTOC_VERSION: "3.19.4"
1818
PYPI_PUBLISH: false
1919
HEAP_APPID_DEV: "3422045963"
@@ -69,7 +69,7 @@ jobs:
6969
esac
7070
7171
- name: Install dependencies
72-
run: make install
72+
run: make telemetry-opt-out install
7373

7474
- name: Install Graphviz
7575
run: sudo apt-get install graphviz

.github/workflows/whylogs-ci.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ defaults:
1313

1414
env:
1515
CODECOV_UPLOAD: false
16-
POETRY_VERSION: "1.2.1"
16+
POETRY_VERSION: "1.4.1"
1717
PROTOC_VERSION: "3.19.4"
1818
PYPI_PUBLISH: false
1919
HEAP_APPID_DEV: "3422045963"
@@ -23,8 +23,8 @@ jobs:
2323
runs-on: ubuntu-latest
2424
strategy:
2525
matrix:
26-
os: [ubuntu-latest, macOS-latest]
27-
python-version: ["3.7", "3.8", "3.9", "3.10"]
26+
os: [ubuntu-latest, macOS-latest, windows-latest]
27+
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11"]
2828

2929
steps:
3030
- uses: actions/checkout@v3
@@ -69,7 +69,7 @@ jobs:
6969
esac
7070
7171
- name: Install dependencies
72-
run: make install
72+
run: make telemetry-opt-out install
7373

7474
- name: Check virtualenv location
7575
run: |

.readthedocs.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ build:
77
jobs:
88
pre_create_environment:
99
- asdf plugin add poetry
10-
- asdf install poetry 1.2.0
11-
- asdf global poetry 1.2.0
10+
- asdf install poetry 1.4.1
11+
- asdf global poetry 1.4.1
1212
- cd python && poetry export -E docs --without-hashes -f requirements.txt --output requirements.txt
1313
- cd python/docs && make pre-build
1414
sphinx:

Dockerfile.dev

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ RUN apt install less -y && \
3333
USER whyuser
3434

3535
WORKDIR /home/whyuser
36-
RUN curl -sSL https://install.python-poetry.org | python3 - --version 1.2.1 && \
36+
RUN curl -sSL https://install.python-poetry.org | python3 - --version 1.4.1 && \
3737
echo 'export PATH="$PATH:$HOME/.local/bin"' >> .bashrc
3838

3939
WORKDIR /workspace

python/Makefile

+3
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,9 @@ test-notebooks: ## Run tests for the notebooks
152152
@$(call i, Running notebook tests)
153153
poetry run pytest --no-cov --maxfail=1 test_notebooks/notebook_tests.py
154154

155+
telemetry-opt-out: ## create opt out file
156+
@$(call i, Creating whylogs telemetry opt-out file)
157+
mkdir ~/.whylogs && echo "" >> ~/.whylogs/disable_telemetry
155158

156159
install: ## Install all dependencies with poetry.
157160
@$(call i, Installing dependencies)

0 commit comments

Comments
 (0)