Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No module named 'typing_extensions' on python 3.11 #1154

Closed
1 task done
jamie256 opened this issue Mar 23, 2023 · 2 comments
Closed
1 task done

No module named 'typing_extensions' on python 3.11 #1154

jamie256 opened this issue Mar 23, 2023 · 2 comments

Comments

@jamie256
Copy link
Contributor

Description

Missing depedency on python 3.11

  • System info
    • Operating system and version: Windows 11
    • python 3.11
  • Steps to reproduce:
    • pip install whylogs
    • import whylogs
Python 3.11.2 (tags/v3.11.2:878ead1, Feb  7 2023, 16:38:35) [MSC v.1934 64 bit (AMD64)]
Type 'copyright', 'credits' or 'license' for more information
IPython 8.11.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import whylogs
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
Cell In[1], line 1
----> 1 import whylogs

File ~\AppData\Local\Programs\Python\Python311\Lib\site-packages\whylogs\__init__.py:18
      1 """
      2 whylogs is an open source library for logging any kind of data. With whylogs, users are able to generate summaries
      3 of their datasets (called whylogs profiles) which they can use to:
   (...)
     16 * And many more...
     17 """
---> 18 from .api import (
     19     ResultSet,
     20     log,
     21     log_classification_metrics,
     22     log_regression_metrics,
     23     logger,
     24     profiling,
     25     read,
     26     reader,
     27     write,
     28 )
     29 from .api.usage_stats import emit_usage as __emit_usage_stats
     30 from .core import DatasetProfileView

File ~\AppData\Local\Programs\Python\Python311\Lib\site-packages\whylogs\api\__init__.py:1
----> 1 from .annotations import profiling
      2 from .logger import (
      3     ResultSet,
      4     log,
   (...)
     10     write,
     11 )
     13 __ALL__ = [
     14     log,
     15     log_classification_metrics,
   (...)
     22     ResultSet,
     23 ]

File ~\AppData\Local\Programs\Python\Python311\Lib\site-packages\whylogs\api\annotations.py:4
      1 from types import FunctionType, LambdaType, MethodType
      2 from typing import Optional, Union
----> 4 from whylogs.api.logger import log
      5 from whylogs.core import DatasetSchema
      7 FuncType = Union[FunctionType, MethodType, LambdaType]

File ~\AppData\Local\Programs\Python\Python311\Lib\site-packages\whylogs\api\logger\__init__.py:4
      1 import logging
      2 from typing import Any, Dict, Optional
----> 4 from typing_extensions import Literal
      6 from whylogs.api.logger.logger import Logger
      7 from whylogs.api.logger.result_set import (
      8     ProfileResultSet,
      9     ResultSet,
     10     ResultSetReader,
     11     SegmentedResultSet,
     12 )

ModuleNotFoundError: No module named 'typing_extensions'

Suggestions

Fix install time dependencies to use typing-extensions on python 3.11

Related

jamie256 added a commit that referenced this issue Mar 24, 2023
## Description

Addresses #1154 and updates test matrix to cover python 3.11 and adds windows
os.

- Upgrade poetry from 1.2.1 to 1.4.1
- updated several dependency versions conditionally on python 3.11: scikit-learn, scipy, numpy, pyarrow, typing-extensions
- whylabs-client version range tighten to prevent future breaking changes in major version bump accidentally being considered compatible with older versions of whylogs.
- refactor datasets module to pass type checking
- skip pyspark tests until there is a pyspark version released that supports python 3.11

- [x] I have reviewed the [Guidelines for Contributing](CONTRIBUTING.md)
and the [Code of Conduct](CODE_OF_CONDUCT.md).
@datatalking
Copy link

@jamie256 if this has been committed is the issue still happening or can we close the issue?

@jamie256
Copy link
Contributor Author

Its merged and should be fixed in next release (or mainline). Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants