Java Loggers #939
Merged
Java Loggers #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 23, 2022 02:35
…ill need to add the rest of the metrics that are currently commented out after ints are done)
…solver to directly call zero() as it builds instead of reflection or through another point
… and if not then true for no columns added
…oring due to metric refactor needed
…ign ... but it's a step
…te some errors, make spotless, build works
…java/profile-and-view
…gger-and-resultset
added 7 commits
October 27, 2022 11:31
…ger will need to be tested after Writers are done.
added 2 commits
October 27, 2022 12:37
java/core/src/main/java/com/whylogs/api/logger/rollingLogger/TimedRollingLogger.java
Show resolved
Hide resolved
java/core/src/main/java/com/whylogs/api/logger/rollingLogger/TimedRollingLogger.java
Outdated
Show resolved
Hide resolved
java/core/src/main/java/com/whylogs/api/logger/rollingLogger/TimedRollingLogger.java
Outdated
Show resolved
Hide resolved
richard-rogers
previously approved these changes
Oct 27, 2022
…nto dev/melly/java/loggers
added 2 commits
October 28, 2022 12:08
added 3 commits
October 28, 2022 12:18
richard-rogers
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This incremental iteration focuses on the Java loggers, but note that the TransientLogger is not done until I do the Writer (next iteration). Please remember while reviewing that the metric we have right now is the Integral Metric going from start to end.
NOTE: This was built off of a branch and then another branch due to PRs. Sadly that's made the commits pretty wild, only the last 10 or so are from this feature and all will be squashed on merge. I did research how to fix that but it looks like best way I saw was on the squash :/