Compose Convert the base color styles #5198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williamrai
added
Ready to merge
cooltey
reviewed
Jan 9, 2025
Comment on lines
47
to
61
| paperColor = ThemeColors.White, | ||
| backgroundColor = ThemeColors.Gray100, | ||
| borderColor = ThemeColors.Gray200, | ||
| inactiveColor = ThemeColors.Gray400, | ||
| placeholderColor = ThemeColors.Gray500, | ||
| secondaryColor = ThemeColors.Gray600, | ||
| primaryColor = ThemeColors.Gray700, | ||
| progressiveColor = ThemeColors.Blue600, | ||
| successColor = ThemeColors.Green700, | ||
| destructiveColor = ThemeColors.Red700, | ||
| warningColor = ThemeColors.Yellow700, | ||
| highlightColor = ThemeColors.Yellow500, | ||
| focusColor = ThemeColors.Orange500, | ||
| additionColor = ThemeColors.Blue300_15, | ||
| overlayColor = ThemeColors.Black_30 |
There was a problem hiding this comment.
Can we have the same order as the WikipediaColor?
| ) | ||
| } | ||
|
|
||
| val lightColors = WikipediaColor( |
There was a problem hiding this comment.
Just curious: the naming here starts with a lowercase, is there anything special meaning for the colors?
There was a problem hiding this comment.
fixed this, it was a function before converting to val that's why it had lowercase.
|
Another idea: do we want to move all Compose-related classes to a |
yes, added a new package called compose |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Convert the base color styles to Compose
Why is this needed?
To make it easier to use our color system with compose.
Phabricator:
https://phabricator.wikimedia.org/T381828
https://phabricator.wikimedia.org/T381910
Testing color base style
#5208