Refactor ReadingListFragment to use ViewModel. #5214
Conversation
app/src/main/java/org/wikipedia/readinglist/ReadingListFragmentViewModel.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # app/src/main/java/org/wikipedia/readinglist/ReadingListFragment.kt
| fun getEmptyTitle(context: Context) = context.getString(R.string.reading_lists_preview_header_title) | ||
|
|
||
| fun getEmptyDescription(context: Context) = DateUtil.getTimeAndDateString(context, Date()) | ||
|
|
||
| suspend fun receiveReadingLists(context: Context, json: String, encoded: Boolean): ReadingList { |
There was a problem hiding this comment.
The following changes make this function unused, would it be possible to avoid/undo the change below?
There was a problem hiding this comment.
Removed the unused function but kept getEmptyTitle and getEmptyDescription so that receiveReadingLists can be used in ViewModels without requiring the Android Context.
There was a problem hiding this comment.
I see, it makes sense to me. Instead of creating separate single-use functions, can we define those strings directly as
val in the updateReadingListData()?
There was a problem hiding this comment.
Sure, I’ve moved these functions to ReadingListFragment
app/src/main/java/org/wikipedia/readinglist/ReadingListFragmentViewModel.kt
Outdated
Show resolved
Hide resolved
| }) { | ||
| val list = AppDatabase.instance.readingListDao().getListById(readingListId, true) | ||
| if (list == null) { | ||
| _updateListByIdFlow.emit(Resource.Error(Throwable("No reading list found with id: $readingListId"))) |
There was a problem hiding this comment.
For better localization, let's move this string into strings.xml. And to ensure accurate translations, could you provide a clear description for it in values-qq/strings.xml
There was a problem hiding this comment.
Just to clarify, do we need this string? The activity finishes without showing a message, so it may not be necessary. Here's the error case:
is Resource.Error -> {
// The list is no longer in the database (likely removed due to sync).
// Nothing to do, so exit the activity.
requireActivity().finish()
}| fun getEmptyTitle(context: Context) = context.getString(R.string.reading_lists_preview_header_title) | ||
|
|
||
| fun getEmptyDescription(context: Context) = DateUtil.getTimeAndDateString(context, Date()) |
There was a problem hiding this comment.
Please see the comment in the previous thread.
What does this do?
ReadingListFragmentto use ViewModel.ReadingListFragmentViewModeland moved the update list logic into it.Why is this needed?
Tech-debt.
Reduce complexity by simplifying the UI layer.
Phabricator:
https://phabricator.wikimedia.org/T303935