Add typecheck (int, float, str) to aocd.models.puzzle.answer_a/b?

[Ryton]

An answer was rejected when send through aocd, when using a float (w/o siginificant digits behind comma) as an input, while it was accepted afterwards from the website, with an int as an input, with the same value. AFAIK, AoC never had any non-whole numbers as the answer in the past?
Expected behaviour:
An int is sent to the website, rather than the float

Potential solution:
Idk how to best catch this unexpected behaviour.
Should the library always send an int? Or do input typecheck on top of valuecheck and give a warning?Maybe change a float answer with mod(X,1)==0 (no significant digits behind comma) to INT?

Example for 6/'22, part A:

Same behaviour for other days 15/'21, for example part B:

was accepted

if you need more info, let me know.
(& kudos for the amazing library!)

[wimglenn]

Hey @Ryton, that's unfortunate, I think we could safely coerce floats which exactly represent integers in aocd. It would be adding something like this here:

if isinstance(val, float) and val.is_integer():
    log.warning("coercing float value")
    val = int(val)

What do you think?

[Ryton]

Yes, sounds good!

Its not a complaint, as indeed its good that your lib transparently transmits types, in case a float is needed as answer in the future.

^
This looks perfect, yes! I doubt it will break any answer case.

[wimglenn]

I think this is a reasonable compromise- the warning should indicate to a user that they probably want to be careful with their answer type, without the possibility of them getting the dreaded "That's not the right answer" response on a technicality.

I will add it when I find the time - or if you would like to prepare a PR to get it in right away, be my guest.

[Ryton]

I could give it a try, but it will need to be thoroughly checked by you, as i'm not as fluent in git-PR'ing.

So yes, challenge accepted! :-)

[Ryton]

TIL how to use the PR cycle ;-)
Thank you! Both AOCD and AoC great learning aids! :-)
(Issue can be closed ofc)

[wimglenn]

If you write "closes #97" somewhere in your PR description (you can edit it in), then this issue will be closed automatically by github when the PR is merged.

[Ryton]

oki.

just checked it, Seems to work at my end:

however, the AoC site down atm? i got an internal server 504 error.
"HTTPError: 500 Server Error: Internal Server Error for url: https://adventofcode.com/2021/day/17"

Edit: 5xx error solved