Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urllib3 #110

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Urllib3 #110

merged 2 commits into from
Mar 24, 2023

Conversation

wimglenn
Copy link
Owner

@wimglenn wimglenn commented Mar 24, 2023

urllib3 is nice enough these days that requests does not really provide much value. May as well cut out the middleman.

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #110 (f02fc1d) into main (23ef80b) will increase coverage by 0.05%.
The diff coverage is 98.93%.

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   92.97%   93.02%   +0.05%     
==========================================
  Files          22       22              
  Lines        2078     2080       +2     
  Branches      253      260       +7     
==========================================
+ Hits         1932     1935       +3     
  Misses        116      116              
+ Partials       30       29       -1     
Impacted Files Coverage Δ
aocd/_ipykernel.py 21.05% <33.33%> (-1.17%) ⬇️
aocd/models.py 94.05% <100.00%> (ø)
aocd/utils.py 88.98% <100.00%> (+0.38%) ⬆️
tests/conftest.py 100.00% <100.00%> (ø)
tests/test_get_data.py 100.00% <100.00%> (ø)
tests/test_models.py 100.00% <100.00%> (ø)
tests/test_runner.py 91.97% <100.00%> (ø)
tests/test_submit.py 100.00% <100.00%> (ø)
tests/test_utils.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wimglenn wimglenn merged commit 21bb601 into main Mar 24, 2023
@wimglenn wimglenn deleted the urllib3 branch March 24, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant