Update utils.py to use urllib3.ProxyManager #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using ProxyManager instead of Poolmanager the proxy settings will be used when provided in proxy_url. Proxy_url can be retrieved from the environment variables
proxy_url = os.environ.get('http_proxy') or os.environ.get('https_proxy')
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
==========================================
- Coverage 91.63% 91.49% -0.15%
==========================================
Files 24 24
Lines 2653 2656 +3
Branches 356 357 +1
==========================================
- Hits 2431 2430 -1
- Misses 158 160 +2
- Partials 64 66 +2 ☔ View full report in Codecov by Sentry. |
wimglenn
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ProxyManager instead of Poolmanager the proxy settings will be used when provided in proxy_url. Proxy_url can be retrieved from the environment variables proxy_url = os.environ.get('http_proxy') or os.environ.get('https_proxy')
closes #128