Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8.4 #1306

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Add support for PHP 8.4 #1306

merged 3 commits into from
Feb 26, 2025

Conversation

LukeTowers
Copy link
Member

@LukeTowers LukeTowers added the maintenance PRs that fix bugs, are translation changes or make only minor changes label Feb 13, 2025
@LukeTowers LukeTowers added this to the 1.2.8 milestone Feb 13, 2025
@LukeTowers LukeTowers changed the title Run tests on 8.4 Add support for PHP 8.4 Feb 13, 2025
@LukeTowers LukeTowers marked this pull request as draft February 13, 2025 06:14
@mjauvin
Copy link
Member

mjauvin commented Feb 19, 2025

@LukeTowers if wintercms/storm#205 gets merged, this should resolve the issue we're having in here.

LukeTowers pushed a commit to wintercms/storm that referenced this pull request Feb 25, 2025
@mjauvin mjauvin self-assigned this Feb 26, 2025
@mjauvin
Copy link
Member

mjauvin commented Feb 26, 2025

I guess this should be closed as @LukeTowers made a direct commit of the same...

@LukeTowers LukeTowers marked this pull request as ready for review February 26, 2025 18:28
@LukeTowers LukeTowers merged commit a0c7e23 into develop Feb 26, 2025
13 checks passed
@LukeTowers LukeTowers deleted the wip/8.4-support branch February 26, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance PRs that fix bugs, are translation changes or make only minor changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants