Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate logging code to winter from storm to prevent excess file logs being written #1319

Merged
merged 4 commits into from
Feb 26, 2025
Merged

Migrate logging code to winter from storm to prevent excess file logs being written #1319

merged 4 commits into from
Feb 26, 2025

Conversation

jaxwilko
Copy link
Member

Relies on: wintercms/storm#208

This PR migrates the sexy logger code into winter. This hooks into the exisiting exception.report event.

This has been done to prevent the detailed logs being written to file, restoring the old style string stack traces when writing to file and the detailed logs are now only written to the db.

LukeTowers pushed a commit to wintercms/storm that referenced this pull request Feb 26, 2025
@jaxwilko
Reverted logger changes and migrated code to winter (#208)
22b9a42 
Related: wintercms/winter#1319
@LukeTowers LukeTowers added this to the 1.2.8 milestone Feb 26, 2025
@LukeTowers LukeTowers added the maintenance PRs that fix bugs, are translation changes or make only minor changes label Feb 26, 2025
@LukeTowers LukeTowers merged commit c95bc06 into develop Feb 26, 2025
11 checks passed
@LukeTowers LukeTowers deleted the fix/logging-too-much branch February 26, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeTowers LukeTowers LukeTowers approved these changes

Assignees
No one assigned
Labels
maintenance PRs that fix bugs, are translation changes or make only minor changes
Projects
None yet
Milestone
1.2.8
Development

Successfully merging this pull request may close these issues.
2 participants
@jaxwilko @LukeTowers