Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move scaffold commands #471

Merged
merged 3 commits into from
Feb 23, 2022
Merged

Move scaffold commands #471

merged 3 commits into from
Feb 23, 2022

Conversation

bennothommo
Copy link
Member

@bennothommo bennothommo commented Feb 23, 2022

Fixes #270.

Moves the Scaffolding commands out of Storm, and into the modules that the scaffold generates code for.

As discussed in the issue above, this makes more sense to keep Storm agnostic, and allows for the commands to be hidden if a particular module is not used in a Winter instance.

@bennothommo bennothommo added maintenance PRs that fix bugs, are translation changes or make only minor changes needs review Issues/PRs that require a review from a maintainer labels Feb 23, 2022
@bennothommo bennothommo added this to the v1.2.0 milestone Feb 23, 2022
@bennothommo bennothommo linked an issue Feb 23, 2022 that may be closed by this pull request
LukeTowers pushed a commit to wintercms/storm that referenced this pull request Feb 23, 2022
@LukeTowers LukeTowers added Status: Completed and removed needs review Issues/PRs that require a review from a maintainer labels Feb 23, 2022
@LukeTowers
Copy link
Member

Thanks @bennothommo!

@LukeTowers LukeTowers merged commit e3fecdb into wip/1.2 Feb 23, 2022
@LukeTowers LukeTowers deleted the wip/1.2-move-scaffold branch February 23, 2022 20:54
@LukeTowers LukeTowers mentioned this pull request Feb 23, 2022
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance PRs that fix bugs, are translation changes or make only minor changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move scaffolding commands into System module
2 participants