Convert afterFetch() method to an event handler for model.afterFetch #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjauvin
added
the
enhancement
mjauvin
changed the title
LukeTowers
reviewed
Mar 14, 2022
|
My test did not work. Steps to reproduce :
form:
fields:
header_images:
label: Header images
span: left
type: fileupload
mode: image
imageWidth: 200
imageHeight: 200When going to theme settings, an error occurs : Model 'Cms\Models\ThemeData' does not contain a definition for 'header_images'. |
|
Closed in favor of #495 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows a plugin to handle the
model.afterFetchevent AFTER the Model handler.The current code uses the
afterFetch()method which always runs AFTER any event handler.ref. https://github.com/wintercms/storm/blob/develop/src/Database/Model.php#L162-L168
The alternative would be to modify the code referenced above in the base Database/Model, but that could lead to breakage in backward compatibility.