-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(channel): add new Channel conversation type [WPB-15865] #3321
base: develop
Are you sure you want to change the base?
Conversation
Transformed `Conversation.Type` from enum to a sealed type, so we can branch groups into Regular and Channel. The same treatment for `ConversationDetails`: Group is split into Regular and Channel. Adapted the checks from `== Group` to `is Group`, as all currently existing logic for groups should be the same for Channels. This does not address persistence, nor API support for channels yet.
|
|
Branch | feat/channels/add-channel-conversation-type |
Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholds
flag.
Click to view all benchmark results
Benchmark | Latency | microseconds (µs) |
---|---|---|
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 694.71 µs |
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 599,146.29 µs |
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,351,492.96 µs |
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 27,015.52 µs |
Datadog ReportBranch report: ✅ 0 Failed, 3419 Passed, 110 Skipped, 1m 2.01s Total Time |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Channels, a new type of group conversation, are being introduced to the app.
They will have their own set of extra features, that regular group conversations won't.
Solutions
Transformed
Conversation.Type
from enum to a sealed type, so we can branch groups into Regular and Channel. The same treatment forConversationDetails
: Group is split into Regular and Channel. Adapted the checks from== Group
tois Group
, as all currently existing logic for groups should be the same for Channels.This does not address persistence, nor API support for channels yet.
Testing
N/A
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.