fix: uncaught exception (#430)

* fix: uncaught exception * fix(Electron template): non-latin text formatting * docs: update DeepSeek
withcatai · Feb 21, 2025 · 599a161 · 599a161
1 parent ca6b901
commit 599a161
Show file tree

Hide file tree

Showing 7 changed files with 24 additions and 5 deletions.
diff --git a/docs/blog/v3.6-deepseek-r1.md b/docs/blog/v3.6-deepseek-r1.md
@@ -1,6 +1,6 @@
 ---
 title: DeepSeek R1 with function calling
-date: 2025-02-21T15:00:00Z
+date: 2025-02-21T19:00:00Z
 lastUpdated: false
 author:
     name: Gilad S.
@@ -90,6 +90,10 @@ Here are some recommended model URIs you can use to try out DeepSeek R1 with fun
 | [DeepSeek R1 Distill Qwen 14B](https://huggingface.co/mradermacher/DeepSeek-R1-Distill-Qwen-14B-GGUF)   | 8.99GB | `hf:mradermacher/DeepSeek-R1-Distill-Qwen-14B-GGUF:Q4_K_M`  |
 | [DeepSeek R1 Distill Qwen 32B](https://huggingface.co/mradermacher/DeepSeek-R1-Distill-Qwen-32B-GGUF)   | 19.9GB | `hf:mradermacher/DeepSeek-R1-Distill-Qwen-32B-GGUF:Q4_K_M`  |
 
+> The 7B model works well with function calling in the first prompt, but tends to deteriorate in subsequent queries.
+> <br/>
+> Use a larger model for better performance with multiple prompts.
+
 ::: info TIP
 Estimate the compatibility of a model with your machine before downloading it using the [`inspect estimate`](../cli/inspect/estimate.md) command:
 ```shell

diff --git a/src/evaluator/LlamaChatSession/utils/LlamaChatSessionPromptCompletionEngine.ts b/src/evaluator/LlamaChatSession/utils/LlamaChatSessionPromptCompletionEngine.ts
@@ -164,7 +164,7 @@ export class LlamaChatSessionPromptCompletionEngine {
                     return this._restartCompletion(completionCache);
             })
             .catch((err) => {
-                if (currentAbortSignal.aborted && err === currentAbortSignal.reason)
+                if ((currentAbortSignal.aborted && err === currentAbortSignal.reason) || err instanceof DOMException)
                     return;
 
                 console.error(getConsoleLogPrefix(false, false), err);

diff --git a/...t/src/App/components/ChatHistory/components/ModelResponseThought/ModelResponseThought.css b/...t/src/App/components/ChatHistory/components/ModelResponseThought/ModelResponseThought.css
@@ -121,6 +121,7 @@
         margin-bottom: 24px;
         opacity: 0.64;
         padding-left: 24px;
+        justify-self: flex-start;
         position: relative;
         overflow: clip;
 
@@ -133,7 +134,7 @@
             width: 4px;
             height: 100%;
             background-color: var(--message-blockquote-border-color);
-            inset-inline-start: 0px;
+            left: 0px;
         }
 
         &.hide {

diff --git a/...t/src/App/components/ChatHistory/components/ModelResponseThought/ModelResponseThought.tsx b/...t/src/App/components/ChatHistory/components/ModelResponseThought/ModelResponseThought.tsx
@@ -36,7 +36,13 @@ export function ModelResponseThought({text, active, duration}: ModelResponseThou
                 <div className="title">{title}</div>
                 <RightChevronIconSVG className="chevron" />
             </span>
-            <MarkdownContent className={classNames("excerpt", isOpen && "hide")} inline>{text.slice(-excerptLength)}</MarkdownContent>
+            <MarkdownContent
+                className={classNames("excerpt", isOpen && "hide")}
+                dir="auto"
+                inline
+            >
+                {text.slice(-excerptLength)}
+            </MarkdownContent>
         </button>
         <MessageMarkdown className={classNames("content", !isOpen && "hide")} activeDot={active}>{text}</MessageMarkdown>
     </div>;

diff --git a/templates/electron-typescript-react/src/App/components/InputRow/InputRow.css b/templates/electron-typescript-react/src/App/components/InputRow/InputRow.css
@@ -82,12 +82,14 @@
                     display: inline;
                     white-space: pre-wrap;
                     word-break: break-word;
+                    unicode-bidi: normal;
                 }
 
                 > .completion {
                     display: inline;
                     white-space: pre-wrap;
                     word-break: break-word;
+                    unicode-bidi: normal;
                 }
 
                 > .pressTab {

diff --git a/templates/electron-typescript-react/src/App/components/MarkdownContent/MarkdownContent.tsx b/templates/electron-typescript-react/src/App/components/MarkdownContent/MarkdownContent.tsx
@@ -18,7 +18,7 @@ const md = markdownit({
     }
 });
 
-export function MarkdownContent({children, inline = false, className}: MarkdownContentProps) {
+export function MarkdownContent({children, inline = false, dir, className}: MarkdownContentProps) {
     const divRef = useRef<HTMLDivElement>(null);
 
     useLayoutEffect(() => {
@@ -34,11 +34,13 @@ export function MarkdownContent({children, inline = false, className}: MarkdownC
     return <div
         className={className}
         ref={divRef}
+        dir={dir}
     />;
 }
 
 type MarkdownContentProps = {
     className?: string,
     inline?: boolean,
+    dir?: string,
     children: string
 };
diff --git a/templates/electron-typescript-react/src/App/components/MessageMarkdown/MessageMarkdown.css b/templates/electron-typescript-react/src/App/components/MessageMarkdown/MessageMarkdown.css
@@ -30,6 +30,10 @@
         margin-bottom: 0px;
     }
 
+    * {
+        unicode-bidi: plaintext;
+    }
+
     h2 {
         margin: 16px 0px;
         padding-top: 24px;