Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): imported element transform to class #2603

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

idoros
Copy link
Collaborator

@idoros idoros commented Jul 11, 2022

This PR fixes an edge case of an imported element type selector (originally defined as type and not class) being transformed as a class selector:

/* origin.st.css */
Part {} /* defined as an "custom" element selector*/
/* entry.st.css */
@st-import [Part as ImportedPart] from './origin.st.css';

ImportedPart {} /* should transfrom to "Part", but wrongly changes to ".origin__Part" */

Notice that selectors like this are not namespaced and should be discouraged.

@idoros idoros added bug Unexpected behavior or exception core Processing and transforming logic labels Jul 11, 2022
@idoros idoros requested a review from barak007 July 11, 2022 07:14
@idoros idoros self-assigned this Jul 11, 2022
@idoros idoros merged commit 378066d into master Jul 11, 2022
@idoros idoros deleted the ido/fix-imported-element-transformation branch July 11, 2022 09:13
@idoros idoros changed the title fix: imported element transform to class fix(core): imported element transform to class Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected behavior or exception core Processing and transforming logic
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants