Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: turn on experimental selector inference by default #2906

Merged
merged 6 commits into from
Oct 16, 2023

Conversation

idoros
Copy link
Collaborator

@idoros idoros commented Sep 20, 2023

This PR flips the default, so that the experimentalSelectorInference flag is on unless explicitly set to false - the false behavior is kept for now, but will be removed in the future within version 6.

  • set default to true
  • report false as unsupported mode that will be removed in a future version
  • change test expectations that relay on the old behavior
  • refactored tests to match new default (kept some experimentalSelectorInference=false to test previous behavior)

As part of the upgrade in the vscode extension, a task must be undertaken to verify the installed @stylable/core version and, if not configured by the user, override the default experimentalSelectorInference setting according to the detected version (false for <=5, true for >=6).

@idoros idoros added core Processing and transforming logic next-major Issues or PR related to the next major version labels Sep 20, 2023
@idoros idoros self-assigned this Sep 20, 2023
@idoros idoros changed the title chore: turn on experimental selector inference by default feat!: turn on experimental selector inference by default Oct 3, 2023
@idoros idoros merged commit a235f6a into master Oct 16, 2023
@idoros idoros deleted the ido/experimental-selector-infer-on-by-default branch October 16, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Processing and transforming logic next-major Issues or PR related to the next major version
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants