Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to support for rollup@4 #2919

Merged
merged 2 commits into from
Oct 25, 2023
Merged

chore: upgrade to support for rollup@4 #2919

merged 2 commits into from
Oct 25, 2023

Conversation

idoros
Copy link
Collaborator

@idoros idoros commented Oct 16, 2023

This PR introduces an upgrade to the tested rollup integration, bumping it up to version 4, and ensure it works.

During testing, one issue surfaced where files loaded via the integration's load hook were not automatically watched. This update addresses this issue by explicitly adding them to the list of watched files within the integration.

Furthermore, it's worth noting that rollup@4 installation includes WASM artifacts, which, in some cases, led to failed installation on Windows machines. This problem was resolved by ensuring that Microsoft Visual C++ is installed. The installer for Microsoft Visual C++ can be obtained from this link: https://aka.ms/vs/17/release/vc_redist.x64.exe.

@idoros idoros added the integration Bundler, test-runner and node label Oct 16, 2023
@idoros idoros requested a review from barak007 October 16, 2023 11:03
@idoros idoros self-assigned this Oct 16, 2023
@barak007
Copy link
Collaborator

Another important change is that Rollup watch mode will no longer watch ids of files that have been loaded via a plugin load hook. So this mainly affects "virtual" files, where it really does not make sense to watch a hard drive location for changes. Instead, it is now up to plugins that use a load hook to manually call this.addWatchFile() for all the files they depend on to handle the load hook.

Did you checked all locations?

@idoros
Copy link
Collaborator Author

idoros commented Oct 19, 2023

The only change is the load hook

@idoros idoros merged commit ac253d8 into master Oct 25, 2023
@idoros idoros deleted the ido/rollup-4 branch October 25, 2023 11:17
idoros added a commit that referenced this pull request Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration Bundler, test-runner and node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants