Error handling improvements for go-mail-middleware #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation and tests still pending
This is the preferred solution of the first thought of direct DKIM implementation in go-mail (see: wneessen/go-mail#28) This commit adds 96% test coverage and minimal documentation via README.md
alexballas
force-pushed
the
feature/improve_error_handling
branch
from
a26e7b3 to
e82b0f3
Compare
…use errors.Is if they want to
alexballas
force-pushed
the
feature/improve_error_handling
branch
from
e82b0f3 to
52b259b
Compare
|
@alexballas Thanks for the PR Alex. Good idea to introduce proper error wraping. |
|
No worries. Let me know if that works for you. Hopefully nothing got messed up during the conflict merging. |
wneessen
approved these changes
Oct 30, 2022
Codecov Report
@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 94.95% 94.93% -0.03%
==========================================
Files 3 3
Lines 218 217 -1
==========================================
- Hits 207 206 -1
Misses 8 8
Partials 3 3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
All looks good. Merge completed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be wrapping sentinel errors where possible and allow users to use
errors.Isif they want to