Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored the package for different PGP encoding schemes #21

Merged
merged 2 commits into from
Jan 28, 2023
Merged

Refactored the package for different PGP encoding schemes #21

merged 2 commits into from
Jan 28, 2023

Conversation

wneessen
Copy link
Owner

  • We now fully support the PGP/Inline encoding scheme
  • Replaced Dhia's go-logger package with the slog package that will soon make it to the Go stdlib
  • Added a NewConfig method for easier config creation
  • Removed the redundant fields from the Middleware struct and replaced it by a Config pointer
  • For PGP/Inline we cannot have alternative body parts and not text/html bodies. These are now deleted
  • Replaced Dhia's custom writer with the stdlib bytes.Buffer
  • In case we run into an error, we now do proper error logging, and we continue the loop
  • Updated the README.md to match the changes
  • Introduced more unit tests. We currently have 58% test coverage

wneessen and others added 2 commits January 27, 2023 18:20
@wneessen
Refactoring the openpgp middleware to implement different types
643280d
@wneessen
Refactored the package
e02df12 
- We now fully support the PGP/Inline encoding scheme
- Replaced Dhia's go-logger package with the `slog` package that will soon make it to the Go stdlib
- Added a `NewConfig` method for easier config creation
- Removed the redundant fields from the `Middleware` struct and replaced it by a `Config` pointer
- For PGP/Inline we cannot have alternative body parts and not text/html bodies. These are now deleted
- Replaced Dhia's custom writer with the stdlib bytes.Buffer
- In case we run into an error, we now do proper error logging, and we continue the loop
- Updated the README.md to match the changes
- Introduced more unit tests. We currently have 58% test coverage
@wneessen wneessen merged commit ab4b69e into main Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wneessen