More work on the PGP Schemes #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
wneessen
commented
Jan 29, 2023
wneessen
commented
- Lots of code rework and cleanup
- More test coverage
- PGP/Inline is basically complete except for some tests
- Cleaned up and refactored a lot of code. - Put the helper functions in its own file - Added re-armoring, so we can add our comments/versions - Fixed log message handling - Put config specific stuff into its own file - Updated go-mail, so we have access to embeds - Added embedded file encryption - Updated SPDX headers
- Cleaned up unneeded code in `pgpInline()` since we can only support plain text type - Added more test coverage
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 86.34% 90.47% +4.13%
==========================================
Files 5 7 +2
Lines 410 441 +31
==========================================
+ Hits 354 399 +45
+ Misses 50 35 -15
- Partials 6 7 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.