Set of backend/frontend fixes #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 29, 2021 13:41
added 2 commits
March 18, 2021 10:50
… url is not replaced with public for the button
szymon-owczarzak
changed the title
added 5 commits
March 18, 2021 15:10
Comment on lines
+48
to
+56
| (data.getJsonArray("actions") | ||
| ?.stream() | ||
| ?.map { it as JsonObject } | ||
| ?.filter { it.containsKey("lastBuiltRevision") } | ||
| ?.toList() | ||
| ?.last() as JsonObject) | ||
| .getJsonObject("lastBuiltRevision") | ||
| ?.getJsonArray("branch") | ||
| ?.first().let { branch = (it as JsonObject).getString("name") } |
There was a problem hiding this comment.
Take lase instead of first branch mentioned in the API response
Comment on lines
-52
to
-60
| <WidgetFooter | ||
| updateTimestamp={updateTimestamp} | ||
| expanded={expanded} | ||
| handleToggle={handleToggle} | ||
| content={content} | ||
| expandContent={expandContent} | ||
| closeWidgets={closeWidgets} | ||
| id={id} | ||
| /> |
There was a problem hiding this comment.
Moved higher in the hierarchy of the elements for better layout
Comment on lines
+194
to
+200
| isAuthenticated && | ||
| isHoover && ( | ||
| <WidgetMenuWrapper status={widgetStatus} theme={theme}> | ||
| <MoreMenu | ||
| color={ | ||
| whiteSpaceInAuthenticatedMode ? 'primary' : 'default' | ||
| } |
There was a problem hiding this comment.
More menu is now shown only when the mouse cursor is above the widget.
| @@ -40,7 +40,7 @@ const ToDoListWidget = ({ id, selectedItems }) => { | |||
| } | |||
| label={ | |||
| <Typography | |||
| variant="subtitle1" | |||
| variant="caption" | |||
There was a problem hiding this comment.
smaller font for items
Comment on lines
+6
to
+10
| margin-left: 8px; | ||
|
|
||
| .MuiSvgIcon-root { | ||
| font-size: 1rem; | ||
| } |
There was a problem hiding this comment.
smaller chcekbox
devzbysiu
approved these changes
Mar 22, 2021
|
Tested & accepted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend Fixes:
moreaction is now visible only when the cursor is above this widgetgo tobuttons from Bamboo, Jenkins, SonarQube widgets and instead make the content clickableLast update timestampand bottom border of the widgetBackend Fixes:
Types of changes
Checklist:
I hereby agree to the terms of the Cogboard Contributor License Agreement.