#345 | Admin session handling improved #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 29, 2021 13:41
token expiration increased to 5 hours
| } | ||
|
|
||
| val SESSION_REFRESHERS = setOf(HttpMethod.POST, HttpMethod.DELETE) |
There was a problem hiding this comment.
All POST and DELETE should now refresh the session
| import io.vertx.reactivex.ext.auth.jwt.JWTAuth | ||
| import io.vertx.reactivex.ext.web.RoutingContext | ||
|
|
||
| open class JwtCommon { |
There was a problem hiding this comment.
Common logic for handling JWT token
| .then(response => response.json()); | ||
| .then(response => { | ||
| if (response.headers.get('token')) { | ||
| setToken(response.headers.get('token')); |
There was a problem hiding this comment.
Any API response can potentially contain refreshed token
| @@ -91,8 +91,7 @@ export const login = (credentials, loginAsGuest) => dispatch => { | |||
| dispatch(pushNotification(NOTIFICATIONS.LOGIN(`Guest: ${guestName}`))); | |||
| } else { | |||
| return fetchData(URL.LOGIN, { method: 'POST', data: credentials }).then( | |||
| ({ token }) => { | |||
| setToken(token); | |||
There was a problem hiding this comment.
moved to fetchData
| @@ -66,7 +66,7 @@ Cypress.Commands.add( | |||
| username: username, | |||
| password: password | |||
| }).then(response => { | |||
| const loginBody = response.body.token.split(' '); | |||
| const loginBody = response.headers['token'].split(' '); | |||
There was a problem hiding this comment.
the token is now returned as a header - as it should be from the begining
token expiration increased to 5 hours
szymon-owczarzak
requested review from
yahorm,
marcin-witaszek-wttech and
YellowFlash525
devzbysiu
previously approved these changes
Mar 25, 2021
marcin-witaszek-wttech
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
It was quite easy to lost changes made to boards due to session expiration.
Types of changes
Checklist:
I hereby agree to the terms of the Cogboard Contributor License Agreement.