Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#344 | Text widget vertical mode fixes #358

Merged
merged 2 commits into from
Apr 2, 2021
Merged

#344 | Text widget vertical mode fixes #358

merged 2 commits into from
Apr 2, 2021

Conversation

marcin-witaszek-wttech
Copy link
Collaborator

@marcin-witaszek-wttech marcin-witaszek-wttech commented Apr 2, 2021 •
edited by szymon-owczarzak
Loading

Description

This PR fixes incorrect rendering of Text widget in vertical mode, which happens right after widget configuration change, before saving and refreshing the page.

#344

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • Automated functional tests have been added or modified to cover my changes (if applicable)
  • I have updated the documentation accordingly.

I hereby agree to the terms of the Cogboard Contributor License Agreement.

@szymon-owczarzak szymon-owczarzak changed the title Fixed rendering vertical text after widget configuration change #344 | Text widget vertical mode fixes Apr 2, 2021
@szymon-owczarzak szymon-owczarzak added the bug Something isn't working label Apr 2, 2021
@szymon-owczarzak szymon-owczarzak linked an issue Apr 2, 2021 that may be closed by this pull request
Widget | Text - better styling (vertical mode) #344
Closed
@GrzegorzBednarski
Copy link
Collaborator

Tested & accepted

@GrzegorzBednarski GrzegorzBednarski merged commit d0dc989 into master Apr 2, 2021
@GrzegorzBednarski GrzegorzBednarski deleted the widget-text-better-styling-vertical-mode branch April 2, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frontendpm frontendpm frontendpm approved these changes

@szymon-owczarzak szymon-owczarzak szymon-owczarzak approved these changes

@Southeaven Southeaven Awaiting requested review from Southeaven

@devzbysiu devzbysiu Awaiting requested review from devzbysiu

@pawel-maslanka-cognifide pawel-maslanka-cognifide Awaiting requested review from pawel-maslanka-cognifide

@YellowFlash525 YellowFlash525 Awaiting requested review from YellowFlash525

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Widget | Text - better styling (vertical mode)
4 participants
@marcin-witaszek-wttech @GrzegorzBednarski @frontendpm @szymon-owczarzak