#288 | Orderable todo list #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcin-witaszek-wttech
previously approved these changes
Apr 2, 2021
Comment on lines
36
to
45
| const handleOnDragEnd = result => { | ||
| if (!result.destination) return; | ||
|
|
||
| const tempItems = buckets; | ||
| const [reorderedItem] = tempItems.splice(result.source.index, 1); | ||
| tempItems.splice(result.destination.index, 0, reorderedItem); | ||
|
|
||
| setBuckets(tempItems); | ||
| onChange(prepareChangeEvent(tempItems, 'array')); | ||
| }; |
There was a problem hiding this comment.
Can we somehow refactor this so we dont have 3 times almost the same code?
marcin-witaszek-wttech
previously approved these changes
Apr 2, 2021
szymon-owczarzak
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
admin is able to change the order of items in todo list
Added drag and drop for todo list.
Checklist:
I hereby agree to the terms of the Cogboard Contributor License Agreement.