Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airframe-sql: Simplify test cases #2639

Merged
merged 1 commit into from
Dec 17, 2022

Conversation

takezoe
Copy link
Member

@takezoe takezoe commented Dec 17, 2022

Simplify TypeResolverTest using shouldMatch to make it easier to maintain and to add further test cases.

@codecov
Copy link

codecov bot commented Dec 17, 2022

Codecov Report

Merging #2639 (d889d01) into master (a32861d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2639   +/-   ##
=======================================
  Coverage   82.12%   82.12%           
=======================================
  Files         333      333           
  Lines       14022    14022           
  Branches     2260     2260           
=======================================
  Hits        11515    11515           
  Misses       2507     2507           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a32861d...d889d01. Read the comment docs.

@takezoe takezoe force-pushed the sql-simplify-test-cases branch from 196c0fb to d889d01 Compare December 17, 2022 04:56
@takezoe takezoe marked this pull request as ready for review December 17, 2022 04:56
@takezoe takezoe requested a review from xerial December 17, 2022 04:58
@xerial
Copy link
Member

xerial commented Dec 17, 2022

Thanks!

@takezoe takezoe merged commit 3c7aa98 into wvlet:master Dec 17, 2022
@takezoe takezoe deleted the sql-simplify-test-cases branch December 17, 2022 05:06
@xerial xerial added the internal Internal changes (usually non-user facing) label Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes (usually non-user facing)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants