-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airspec: #2637 Support selecting nested test specs #2651
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2651 +/- ##
=======================================
Coverage 82.12% 82.13%
=======================================
Files 334 334
Lines 14030 14030
Branches 2182 2182
=======================================
+ Hits 11522 11523 +1
+ Misses 2508 2507 -1
Continue to review full report at Codecov.
|
I think slash separator is a bit awkward, but may be fine for AirSpec's nesting MUnit also use BTW, one can select tests with the following format.
Some styles of ScalaTest supports nested tests. class FooSpec extends org.scalatest.funspec.AnyFunSpec {
describe("A Set") {
describe("when empty") {
it("should have size 0") {
assert(Set.empty.size == 0)
}
it("should produce NoSuchElementException when head is invoked") {
assertThrows[NoSuchElementException] {
Set.empty.head
}
}
}
}
} then one can select child test cases with
I think whitespace separator is more reasonable in |
Interesting. We might want to allow both whitespace and slash as a separator because we often group test cases just by the category name when we write test cases in AirSpec. |
Thanks. AirSpec allows partial match of the test names so that the user doesn't always need to specify the full test names with wildcard(*) like ScalaTest -z option is interesting, but if the same keyword appears multiple times like
In this case, it's a bit difficult to specify test paths like `testA/* because -z "test A" will run everything in this example as the keyword "test A" appears in all of the child paths. |
Let me try this /-slash separator first and figure out if it's better to support other pattern matches like -z :) |
Support selecting nested test cases with
(test name)/(child test name)/...
syntax.Could you take a look? @takezoe @exoego