Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-116 Correctly compile and fix Hazelcast2CacheMetrics #119

Merged
merged 4 commits into from
Jul 12, 2021
Merged

Conversation

kerkhofsd
Copy link
Contributor

Fixes #116

@kerkhofsd kerkhofsd requested a review from thijslemmens July 9, 2021 14:26
@thijslemmens
Copy link
Contributor

@kerkhofsd Shouldn't we add caching metrics to the smoke tests?

@driesdeproost
Copy link

build fails though

@kerkhofsd
Copy link
Contributor Author

@thijslemmens problem is that this problem doesn't show in current integration testing setup,

It requires a clustered Alfresco environment (including a valid license)...

@thijslemmens
Copy link
Contributor

thijslemmens commented Jul 9, 2021 via email

@kerkhofsd kerkhofsd changed the title gh-116 Invoke IMap#getPutOperationCount() with reflection for Hazelcast 2 versions gh-116 Correctly compile and fix Hazelcast2CacheMetrics Jul 12, 2021
@kerkhofsd
Copy link
Contributor Author

To avoid the need of reflection in Hazelcast2CacheMetrics, we now compile against and build with an older, fixed Hazelcast version (2.4).
In new Alfresco versions, the OOTBox HazelcastCacheMetrics, included in Micrometer, is used anyway.

Added some minimal tests for the Hazelcast2CacheMetrics class.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.9% 90.9% Coverage
0.0% 0.0% Duplication

@kerkhofsd kerkhofsd merged commit 04a71ad into master Jul 12, 2021
@kerkhofsd kerkhofsd deleted the gh-116 branch July 12, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus endpoint raises ERROR when caching metrics enabled
3 participants