Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#22] Add CMS-concurrent-* gc events parsing. #42

Merged
merged 1 commit into from
Jun 2, 2016
Merged

Conversation

ducky-hong
Copy link
Collaborator

  • CMS_CONCURRENT LogType added on gc_model.
  • CMS concurrent cpu time, wall time added.
  • Avoid potential NPE on CmsLogParser#parseGcEvent.

@xeoh
Copy link
Owner

xeoh commented May 31, 2016

We know that some CMS concurrent mode fail in middle of procedure. I think dividing concurrent mode more specific will give us more informations.

Category of concurrent mode.

2015-05-26T16:23:07.321-0200: 64.425: [GC (CMS Initial Mark) [1 CMS-initial-mark: 10812086K(11901376K)] 10887844K(12514816K), 0.0001997 secs] [Times: user=0.00 sys=0.00, real=0.00 secs]
2015-05-26T16:23:07.321-0200: 64.425: [CMS-concurrent-mark-start]
2015-05-26T16:23:07.357-0200: 64.460: [CMS-concurrent-mark: 0.035/0.035 secs] [Times: user=0.07 sys=0.00, real=0.03 secs]
2015-05-26T16:23:07.357-0200: 64.460: [CMS-concurrent-preclean-start]
2015-05-26T16:23:07.373-0200: 64.476: [CMS-concurrent-preclean: 0.016/0.016 secs] [Times: user=0.02 sys=0.00, real=0.02 secs]
2015-05-26T16:23:07.373-0200: 64.476: [CMS-concurrent-abortable-preclean-start]
2015-05-26T16:23:08.446-0200: 65.550: [CMS-concurrent-abortable-preclean: 0.167/1.074 secs] [Times: user=0.20 sys=0.00, real=1.07 secs]
2015-05-26T16:23:08.447-0200: 65.550: [GC (CMS Final Remark) [YG occupancy: 387920 K (613440 K)]65.550: [Rescan (parallel) , 0.0085125 secs]65.559: [weak refs processing, 0.0000243 secs]65.559: [class unloading, 0.0013120 secs]65.560: [scrub symbol table, 0.0008345 secs]65.561: [scrub string table, 0.0001759 secs][1 CMS-remark: 10812086K(11901376K)] 11200006K(12514816K), 0.0110730 secs] [Times: user=0.06 sys=0.00, real=0.01 secs]
2015-05-26T16:23:08.458-0200: 65.561: [CMS-concurrent-sweep-start]
2015-05-26T16:23:08.485-0200: 65.588: [CMS-concurrent-sweep: 0.027/0.027 secs] [Times: user=0.03 sys=0.00, real=0.03 secs]
2015-05-26T16:23:08.485-0200: 65.589: [CMS-concurrent-reset-start]
2015-05-26T16:23:08.497-0200: 65.601: [CMS-concurrent-reset: 0.012/0.012 secs] [Times: user=0.01 sys=0.00, real=0.01 secs]

@ducky-hong
Copy link
Collaborator Author

I could add all cms concurrent type to GcEvent.LogType. But, those are too many. How about remove the LogType enum and change it just string?

@xeoh
Copy link
Owner

xeoh commented May 31, 2016

It's fine. Let's make it as String.

@ducky-hong
Copy link
Collaborator Author

@JeOhLee
I tried to replace LogType to string type, but FULL_GC consists of Full Gc and ParNew - CMS which are not directly mapped to logs. I am considering to add raw_type which represents a raw log type. For example, ParNew CMS, Full GC, CMS-concurrent-{mark, preclean, abortable-preclean}, etc.

- CMS_CONCURRENT LogType added on gc_model.
- CMS concurrent cpu time, wall time added.
- Avoid potential NPE on CmsLogParser#parseGcEvent.
@ducky-hong
Copy link
Collaborator Author

I added type_detail field on GcEvent model. This field represents literally type details. For example, on concurrent mode exception case, type_detail field has a value Full GC (Allocation Failure); CMS (concurrent mode failure); Meatspace.

@xeoh
Copy link
Owner

xeoh commented Jun 2, 2016

LGTM

1 similar comment
@dansuh17
Copy link
Collaborator

dansuh17 commented Jun 2, 2016

LGTM

@ducky-hong
Copy link
Collaborator Author

@densuh @JeOhLee
우리 마지막에 확인한 사람이 머지해주는건 어떨까요... 셀프머지하려니 눈물이... 😭

@ducky-hong ducky-hong merged commit e84827d into develop Jun 2, 2016
@xeoh xeoh deleted the iss22-cms branch June 3, 2016 05:21
@ducky-hong ducky-hong restored the iss22-cms branch June 8, 2016 10:22
@ducky-hong ducky-hong deleted the iss22-cms branch June 8, 2016 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants