-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#22] Add CMS-concurrent-* gc events parsing. #42
Conversation
ducky-hong
commented
May 30, 2016
- CMS_CONCURRENT LogType added on gc_model.
- CMS concurrent cpu time, wall time added.
- Avoid potential NPE on CmsLogParser#parseGcEvent.
We know that some CMS concurrent mode fail in middle of procedure. I think dividing concurrent mode more specific will give us more informations. Category of concurrent mode.
|
I could add all cms concurrent type to GcEvent.LogType. But, those are too many. How about remove the LogType enum and change it just string? |
It's fine. Let's make it as String. |
@JeOhLee |
- CMS_CONCURRENT LogType added on gc_model. - CMS concurrent cpu time, wall time added. - Avoid potential NPE on CmsLogParser#parseGcEvent.
I added |
LGTM |
1 similar comment
LGTM |
@densuh @JeOhLee |