Don't escape quotes in args on Windows

This was added recently to enable shell arguments to work on Windows
however I don't think we want to escape quotes but instead rely on the
consumer escaping the quotes since some windows commands require quotes
not to be escaped (eg. cmd.exe /c "dir "a b"").

Fixes microsoft#41

src/windowsPtyAgent.ts

@@ -110,10 +110,6 @@ export function argvToCommandLine(argv: string[]): string {
       const p = arg[i];
       if (p === '\\') {
         bsCount++;
-      } else if (p === '"') {
-        result += repeatText('\\', bsCount * 2 + 1);
-        result += '"';
-        bsCount = 0;
       } else {
         result += repeatText('\\', bsCount);
         bsCount = 0;

test/argvToCommandLine.js

@@ -18,11 +18,11 @@ describe("argvToCommandLine", function() {
     it("doesn't escape multiple backslashes", function() {
       check(['asdf\\\\qwer'], 'asdf\\\\qwer');
     });
-    it("adds backslashes before quotes", function() {
-      check(['"asdf"qwer"'], '\\"asdf\\"qwer\\"');
+    it("should not add backslashes before quotes", function() {
+      check(['"asdf"qwer"'], '"asdf"qwer"');
     });
-    it("escapes backslashes before quotes", function() {
-      check(['asdf\\"qwer'], 'asdf\\\\\\"qwer');
+    it("escapes backslashes, not quotes", function() {
+      check(['asdf\\"qwer'], 'asdf\\"qwer');
     });
   });
 
@@ -42,11 +42,11 @@ describe("argvToCommandLine", function() {
     it("doesn't escape multiple backslashes", function() {
       check(['asdf \\\\qwer'], '"asdf \\\\qwer"');
     });
-    it("adds backslashes before quotes", function() {
-      check(['"asdf "qwer"'], '"\\"asdf \\"qwer\\""');
+    it("doesn't escape quotes", function() {
+      check(['"asdf "qwer"'], '""asdf "qwer""');
     });
-    it("escapes backslashes before quotes", function() {
-      check(['asdf \\"qwer'], '"asdf \\\\\\"qwer"');
+    it("escapes backslashes, not quotes", function() {
+      check(['asdf \\"qwer'], '"asdf \\"qwer"');
     });
     it("escapes multiple backslashes at the end", function() {
       check(['asdf qwer\\\\'], '"asdf qwer\\\\\\\\"');
@@ -55,7 +55,7 @@ describe("argvToCommandLine", function() {
 
   describe("Multiple arguments", function() {
     it("joins arguments with spaces", function() {
-      check(['asdf', 'qwer zxcv', '', '"'], 'asdf "qwer zxcv" "" \\"');
+      check(['asdf', 'qwer zxcv', '', '"'], 'asdf "qwer zxcv" "" "');
     });
   });
 });