[FEATURE] Add a custom user groups event #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* to map the groups by a a different pattern if "Roles" does not fit * for example work with "claims" or "group_membership" data in a custom listener
|
Please add proper typehints wherever possible |
# Conflicts: # Classes/Service/AuthenticationService.php
|
Added them (support for PHP v7.4 still needed). |
|
If #152 is accepted, I'd suggest adding the reference to the auth service for this new event as well. |
|
@denislorch #152 is merged please add the reference as well here, so we can proceed with this one. Please also add some info about the new event to the changelog file |
* Add auth service instance * Align event class * Add CHANGELOG entry
|
Streamlined to latest changes, to be a part of the next release. |
|
Looks good to me. Thanks. |
liayn
approved these changes
Jul 9, 2024
xperseguers
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-Implement #86 under v2.0.0 (TYPO3 v11)