Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have integration tests run their own server on a port other than 3000 #2714

Closed
Tyriar opened this issue Feb 12, 2020 · 0 comments · Fixed by #3298
Closed

Have integration tests run their own server on a port other than 3000 #2714

Tyriar opened this issue Feb 12, 2020 · 0 comments · Fixed by #3298
Labels
help wanted type/debt Technical debt that could slow us down in the long run

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 12, 2020

Right now the tests rely on the demo being up and running on port 3000, it would be nicer if instead the tests set up their own server on a different port and tore it down after running the tests.
@Tyriar Tyriar added help wanted type/debt Technical debt that could slow us down in the long run labels Feb 12, 2020
@Tyriar Tyriar mentioned this issue Feb 15, 2020
Merged
bmf-ribeiro pushed a commit to bmf-ribeiro/xterm.js that referenced this issue Apr 6, 2021
Fix xtermjs#2714 - Start demo server before running integration tests
27c8731 
 - Use port 3001 instead of  300 to not conflict with the demo
@bmf-ribeiro bmf-ribeiro mentioned this issue Apr 6, 2021
Merged
Tyriar added a commit that referenced this issue Apr 6, 2021
@Tyriar
Merge pull request #3298 from bmf-ribeiro/feat/2714-start-server-on-i…
6370a93 
…ntegration-tests

Fix #2714 - Start demo server before running integration tests
This was referenced May 10, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2714 - Start demo server before running integration tests bmf-ribeiro/xterm.js
1 participant
@Tyriar