Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying a wrapped line results in a newline at the end of the wrapped line #443

Closed
akalipetis opened this issue Jan 3, 2017 · 5 comments
Assignees
Labels
type/bug Something is misbehaving
Milestone

Comments

@akalipetis
Copy link
Contributor

Copying and pasting a wrapped line, introduces a newline character at the position the line was wrapped.

Steps to reproduce

  1. Open the demo
  2. Paste a long echo line, like the one below:
    echo this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big
    
  3. When copied, the resulting line should be:
    this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big
    
  4. It actually is:
    this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-
    is-big-this-is-big-this-is-big-this-is-big-this-is-big-this-is-big
    
@akalipetis
Copy link
Contributor Author

For a real-world example, you can see play-with-docker/play-with-docker#66

@marcosnils
Copy link

@Tyriar do you think this is easy to fix?

@Tyriar
Copy link
Member

Tyriar commented Mar 12, 2017

@marcosnils not at the moment as this is blocked on #325, that change wwill properly track and re-wrap lines when resized, This should encode information for lines spanning multiple rows.

Once that is done though, ClipboardHandler here will just need to grab that line/row information and remove the problem new lines.

@cancan101
Copy link

Now that #325 is fixed, where does this issue stand (I am seeing it on: jupyter/notebook#2256)?

@Tyriar
Copy link
Member

Tyriar commented Apr 21, 2017

The PR for #325 only fixed a portion of the problem, this is now blocked on #622 which has a (big) PR out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is misbehaving
Projects
None yet
Development

No branches or pull requests

4 participants