Improve unicode string handling in linkifier #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review 😸 |
Tyriar
requested changes
Sep 14, 2018
|
@Tyriar I think I have addressed all review issues. Up for the next round 😸 Could you also test the issue from #1669 (comment) again? I think it is not related to the linkifier at all and will need separate tracking before closing the issue. |
Tyriar
approved these changes
Sep 14, 2018
There was a problem hiding this comment.
LGTM, I checked 3.4.0 and #1669 (comment) doesn't appear to be a regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to do several changes to get the cell/length offset mess working. This PR shall fix #1669.
Changes in
Buffer.ts:BufferStringIterator: class to get a hold of the buffer string content in a convenient wayBuffer.stringIndexToBufferIndex: method to translate a string index from a string retrieved byBuffer.translateBufferLineToStringto get the row and cols indices in the buffer. Atm this method assumes that the string started at col 0.(Can be changed easily to respectstartColas well.)Buffer.contents: return aBufferStringIteratorChanges in
Linkifier.ts:_linkifyRowand_doLinkifyRowTODO:
Linkifier._addLinkto support unicode char offsets within a match (currently only pre/post match offsets are respected)@alexr00 The new methods inBuffercan also fix the highlight offset problems of the selection manager. Might be worth a look once this PR can land.Seems to work now.issue created #1680 + #1686