Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geesefs as module? #128

Closed
benallfree opened this issue Dec 27, 2024 · 2 comments
Closed

geesefs as module? #128

benallfree opened this issue Dec 27, 2024 · 2 comments

Comments

@benallfree
Copy link

Hello, I made a PR against the Tigris fork tigrisdata/geesefs#2 proposing to rename internal to core so this package can be used as a module.

Are you guys interested in this? If so, I can make the PR here instead and then move it upstream to the Tigris fork.
@vitalif
Copy link
Collaborator

vitalif commented Jan 9, 2025

Hi!
I'm totally OK with renaming.
One question - why did they fork geesefs at all?
If they need any specific support for their backend they can create a PR and add it here. :-)

@vitalif
Copy link
Collaborator

vitalif commented Jan 9, 2025

I think I'll even do the rename myself now)

@vitalif vitalif closed this as completed in 2a3c6ad Jan 9, 2025
vitalif added a commit that referenced this issue Jan 9, 2025
@vitalif
Rename internal/ to core/ - fixes #128
ecec258
vitalif added a commit that referenced this issue Jan 9, 2025
@vitalif
Rename internal/ to core/ - fixes #128
cbaa374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitalif @benallfree