Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Upgrade murmur3 hashing to XXH3 hashing #1

Closed
glmcdona opened this issue Feb 9, 2023 · 3 comments
Closed

Request: Upgrade murmur3 hashing to XXH3 hashing #1

glmcdona opened this issue Feb 9, 2023 · 3 comments

Comments

@glmcdona
Copy link

glmcdona commented Feb 9, 2023

Awesome project! This worked great out of the box and was a speedup of around 10x from the previous package I was using.

See XXH3 hashing here:
https://cyan4973.github.io/xxHash/

It's about 10x the speed of murmur3 according to their benchmarks there. This I think would probably speed up this bloom filter implementation even further.

@yankun1992
Copy link
Owner

Looks very good, I'll do some benchmarking to see how much of a performance boost there is!

@glmcdona
Copy link
Author

glmcdona commented Feb 9, 2023

Just a note, that I think by that benchmark it'd be more likely ~2.4x faster hashing, not 10x that I mentioned above. Since this would be small value hashing.

yankun1992 added a commit that referenced this issue Feb 10, 2023
ci: cross platform for rust and python unittest.
@yankun1992
Copy link
Owner

Upgrade to version 0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants