Skip to content

Commit

Permalink
Fixes topLevel dependencies (#6712)
Browse files Browse the repository at this point in the history
## What's the problem this PR addresses?

I noticed while refactoring code that one test wasn't correct, and was
hiding a bug in PnP. The locator `{name: null, reference: null}` was
returning different dependencies than `{name: "root", reference:
"workspace:."}`, which isn't expected.

## How did you fix it?

Refactored how we assign the `null` / `null` package entry - it's now
handled directly into `generateSerializedState` rather than the caller.

## Checklist

<!--- Don't worry if you miss something, chores are automatically
tested. -->
<!--- This checklist exists to help you remember doing the chores when
you submit a PR. -->
<!--- Put an `x` in all the boxes that apply. -->
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).

<!-- See
https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
for more details. -->
<!-- Check with `yarn version check` and fix with `yarn version check
-i` -->
- [x] I have set the packages that need to be released for my changes to
be effective.

<!-- The "Testing chores" workflow validates that your PR follows our
guidelines. -->
<!-- If it doesn't pass, click on it to see details as to what your PR
might be missing. -->
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.
  • Loading branch information
arcanis authored Mar 4, 2025
1 parent 64d6a82 commit 477c963
Show file tree
Hide file tree
Showing 5 changed files with 1,722 additions and 1,678 deletions.
Loading

0 comments on commit 477c963

Please sign in to comment.