Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub API rate limits #6905

Closed
billyvg opened this issue Jan 10, 2019 · 0 comments · Fixed by #6912
Closed

GitHub API rate limits #6905

billyvg opened this issue Jan 10, 2019 · 0 comments · Fixed by #6912
Assignees
@torifat
Labels
triaged

Comments

@billyvg
Copy link
Contributor

billyvg commented Jan 10, 2019 •
edited
Loading

Do you want to request a feature or report a bug?
Both?

What is the current behavior?
We are hitting GitHub API rate limits

error An unexpected error occurred: "https://api.github.com/repos/yarnpkg/yarn/releases: API rate limit exceeded for ***. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)".

(this happens when trying to use the new yarn policies set-version command)

What is the expected behavior?
We should be able to define a github access token via an environment variable so that github requests are authd
@ghost ghost assigned torifat Jan 10, 2019
@ghost ghost added the triaged label Jan 10, 2019
billyvg added a commit to billyvg/yarn that referenced this issue Jan 12, 2019
@billyvg
feat(policies): Use github access token when requesting releases
87e3799 
If the environment variable `GITHUB_TOKEN` is defined, append `?access_token=<GITHUB_TOKEN>` when requesting yarn releases from GitHub.

Closes yarnpkg#6905
This was referenced Jan 12, 2019
Closed
Merged
arcanis pushed a commit that referenced this issue Jan 14, 2019
@billyvg @arcanis
feat(policies): Use github access token when requesting releases (#6912)
94f83d6 
* feat(policies): Use github access token when requesting releases

If the environment variable `GITHUB_TOKEN` is defined, append `?access_token=<GITHUB_TOKEN>` when requesting yarn releases from GitHub.

Closes #6905

* fix lint

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@torifat torifat

Labels
triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(policies): Use github access token when requesting releases billyvg/yarn
2 participants
@billyvg @torifat