Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added labels input to save_url method #3

Merged
merged 4 commits into from
Jun 16, 2024

Conversation

naveennamani
Copy link
Contributor

πŸ“‘ Description

Now, labels can be added when saving a url by calling with save_url(url, ["label1", "label2"]).

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Now, labels can be added when saving a url by calling with `save_url(url, ["label1", "label2"]`.
@yazdipour
Copy link
Owner

Hey Naveen, Thanks for your contribution. You need to update the unittest to match your changes before PR.

@naveennamani
Copy link
Contributor Author

Dear @yazdipour, I've added a unittest test case test_save_url_with_labels. Also, I fixed an error in passing the input values, and all the test cases are now passing.

@yazdipour yazdipour merged commit d67ad49 into yazdipour:main Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants