Implement https://php.watch/versions/8.3/typed-constants #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossaddison
commented
Jan 24, 2025
rossaddison
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
Fix readme badges (yiisoft#219)
Perhaps https://stackoverflow.com/questions/28865066/phpunit-fails-asserting-that-two-arrays-are-equal-but-shows-no-difference has relevance here. "Found the issue. Elements were not in the same order. A bit annoying though that the output doesn't show it." "I have replaced assertEquals with: $this->assertTrue($this->similar_arrays($arr1, $arr2)); protected function similar_arrays($a, $b) { if(is_array($a) && is_array($b)) { if(count(array_diff(array_keys($a), array_keys($b))) > 0) return false; foreach($a as $k => $v) { if(!$this->similar_arrays($v, $b[$k])) return false; } return true; } else return $a === $b; }" The test passes when 'title' => 'string' is inserted so that the arrays are equal in terms of 'key-value pair' count and not in the same order.
roxblnfk
requested changes
Jan 25, 2025
|
You can use /**
* @psalm-suppress MissingClassConstType
*/
final public const TYPE_SUMMARY = 'summary'; |
xepozz
reviewed
Jan 25, 2025
| @@ -39,20 +39,11 @@ jobs: | |||
| - windows-latest | |||
|
|
|||
| php: | |||
| - 8.1 | |||
| - 8.2 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.