Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YouTube] Fix bit-shift coercion for player 9c6dfc4a #33049

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

dirkf
Copy link
Contributor

@dirkf dirkf commented Feb 6, 2025

Boilerplate: own code, bug fix

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This PR improves argument coercion for bit-shift (and by extension, other bit-oriented operations) to cater for float together with other not-apparently-bit values, some of which were formerly checked individually. Fixes #33048.

Also included is a pending clean-up of an accidentally public compat interface.

* if required, not supported:
`from youtube_dl.casefold import _casefold as casefold`
@dirkf dirkf force-pushed the jsinterp_fix_33048 branch from 004a07f to 8ba28b7 Compare February 6, 2025 21:10
@dirkf dirkf merged commit 711e72c into ytdl-org:master Feb 7, 2025
14 checks passed
@dirkf dirkf deleted the jsinterp_fix_33048 branch February 7, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[YouTube] Unable to decode n-parameter with player 9c6dfc4a
1 participant