-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nose to pytest #1239
Merged
Merged
Nose to pytest #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with ``` pipenv install --dev pytest pipenv install --dev pytest-cov ```
when running tests there was this warning: ``` DeprecationWarning: 'werkzeug.urls.url_unquote' is deprecated and will be removed in Werkzeug 2.4. Use 'urllib.parse.unquote' instead. ```
``` DeprecationWarning: Please use assertRegex instead of assertRegexpMatches ```
monkut
approved these changes
May 3, 2023
thanks for the hard work! |
``` DeprecationWarning: Please use assertRaisesRegex instead of assertRaisesRegexp ```
``` DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead ```
``` DeprecationWarning: Please use assertEqual instead of assertEquals ```
keeping coverage results (aggregated) and duration display
hellno
approved these changes
May 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing effort, thank you! 🙌🏽🙌🏽 LGTM
Ian288
pushed a commit
to tackle-io/Zappa
that referenced
this pull request
Jul 11, 2023
* lint: updating code style with `make black` * adding pytest related package with ``` pipenv install --dev pytest pipenv install --dev pytest-cov ``` * wsgi: fixing DeprecationWarning when running tests there was this warning: ``` DeprecationWarning: 'werkzeug.urls.url_unquote' is deprecated and will be removed in Werkzeug 2.4. Use 'urllib.parse.unquote' instead. ``` * tests: using `redirect_stdout` to redirect stdout to a readable source * tests_utilities: fixing deprecation warning ``` DeprecationWarning: Please use assertRegex instead of assertRegexpMatches ``` * tests_utilities: removing try/finally in test_certify_sanity_checks * tests_placebo: : fixing deprecation warning ``` DeprecationWarning: Please use assertRaisesRegex instead of assertRaisesRegexp ``` * zappa(core): fixing deprecation warning ``` DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead ``` * tests_docs: fixing deprecation warning ``` DeprecationWarning: Please use assertEqual instead of assertEquals ``` * tests: moving from nose to pytest keeping coverage results (aggregated) and duration display * tests: removing and uninstalling all nose references
BarNehemia
pushed a commit
to Lightricks/Zappa
that referenced
this pull request
Aug 10, 2023
…zappa-0.57.0 * commit '0b1eab14ca39c3a3bfb4e915347e07495171dcba': (27 commits) updating workflow actions to remove deprecation warnings (zappa#1243) 📝 CHANGELOG.md update for 0.57.0 (zappa#1246) fixing compatibility with Django 4.2 (zappa#1237) Update Readme with patreon and donors (zappa#1234) adding support for Python 3.10 (zappa#1231) Nose to pytest (zappa#1239) lint: updating code style with `make black` (zappa#1238) Alternative way to check if running in Docker (zappa#1204) 📝 CHANGELOG.md update for 0.56.0 release (zappa#1187) Improve `get_best_match_zone()` to match by most matched components instead of by length of domain (zappa#1193) Bypass python version runtime check when code run in docker (zappa#1180) Be able to pass in a batch window when using batch size (zappa#1118) Correction to README. (zappa#1177) (zappa#908) Update BINARY_SUPPORT to use Content-Encoding to identify if data is binary (zappa#1155) Remove special check for Django<1.7, fix for zappa#1158 (zappa#1159) Resolve (zappa#410) Logs are missing query strings (zappa#1165) Handle spaces in x-forwared-for/remove six (zappa#1127) (zappa#1163) add feature (zappa#704) Check if args/kwargs are JSON Serializable while running locally (zappa#1154) docs: Add documentation for s3 event object key_filters (zappa#1169) Add feature pyenv virtualenv detecting .python-version file (zappa#1153) ... # Conflicts: # zappa/cli.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating test suite from the old
nose
to the newpytest
, keeping coverage results (aggregated) and duration display.Inspired by @monkut in #1231 (comment)
This PR goes after this one: #1238
in order to preserve style formatting there and use it from now on.
#1146